Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out unused paramter #39

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Comment out unused paramter #39

merged 1 commit into from
Oct 30, 2022

Conversation

ijnek
Copy link
Member

@ijnek ijnek commented Oct 28, 2022 •
edited
Loading

Fixes the following warning:

--- stderr: dynamixel_hardware        
/home/ijnek/tmp_workspaces/dynamixel_control_ws/src/dynamixel_hardware/src/dynamixel_hardware.cpp: In member function ‘virtual hardware_interface::CallbackReturn dynamixel_hardware::DynamixelHardware::on_activate(const rclcpp_lifecycle::State&)’:
/home/ijnek/tmp_workspaces/dynamixel_control_ws/src/dynamixel_hardware/src/dynamixel_hardware.cpp:219:79: warning: unused parameter ‘previous_state’ [-Wunused-parameter]
  219 | amixelHardware::on_activate(const rclcpp_lifecycle::State & previous_state)
      |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~

/home/ijnek/tmp_workspaces/dynamixel_control_ws/src/dynamixel_hardware/src/dynamixel_hardware.cpp: In member function ‘virtual hardware_interface::CallbackReturn dynamixel_hardware::DynamixelHardware::on_deactivate(const rclcpp_lifecycle::State&)’:
/home/ijnek/tmp_workspaces/dynamixel_control_ws/src/dynamixel_hardware/src/dynamixel_hardware.cpp:236:81: warning: unused parameter ‘previous_state’ [-Wunused-parameter]
  236 | ixelHardware::on_deactivate(const rclcpp_lifecycle::State & previous_state)
      |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~

---

Should be backported to galactic and humble too.

@ijnek
comment out unused paramter
8aadea3 
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
youtalk
youtalk approved these changes Oct 30, 2022
View reviewed changes
Copy link
Collaborator

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit c801c5a into dynamixel-community:rolling Oct 30, 2022
@ijnek ijnek deleted the ijnek-unused-parameters branch October 30, 2022 12:01
youtalk added a commit that referenced this pull request Nov 6, 2022
@youtalk
Merge pull request #48 from ijnek/ijnek-galactic-unused-parameter
ea492d9 
Backport of #39 to Galactic
youtalk added a commit that referenced this pull request Nov 6, 2022
@youtalk
Merge pull request #47 from ijnek/ijnek-humble-unused-parameter
9553609 
Backport of #39 to Humble
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtalk youtalk youtalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijnek @youtalk