mysqlctl: remove lower_case_table_names setting

Issue #3158
The current value of 0 is definitely incorrect because vitess
treats table names as case-sensitive. It's better we don't set
this variable at all. Let the users decide what it should be.

config/mycnf/default-fast.cnf

@@ -58,6 +58,3 @@ thread_cache_size = 200
 tmpdir = {{.TmpDir}}
 tmp_table_size = 32M
 transaction-isolation = REPEATABLE-READ
-# READ-COMMITTED would be better, but mysql 5.1 disables this with statement based replication
-# READ-UNCOMMITTED might be better
-lower_case_table_names = 1

config/mycnf/default.cnf

@@ -56,9 +56,6 @@ thread_cache_size = 200
 tmpdir = {{.TmpDir}}
 tmp_table_size = 32M
 transaction-isolation = REPEATABLE-READ
-# READ-COMMITTED would be better, but mysql 5.1 disables this with statement based replication
-# READ-UNCOMMITTED might be better
-lower_case_table_names = 1
 
 # Semi-sync replication is required for automated unplanned failover
 # (when the master goes away). Here we just load the plugin so it's

test/keyspace_test.py

@@ -22,8 +22,8 @@
 import tablet
 import utils
 
-SHARDED_KEYSPACE = 'TEST_KEYSPACE_SHARDED'
-UNSHARDED_KEYSPACE = 'TEST_KEYSPACE_UNSHARDED'
+SHARDED_KEYSPACE = 'test_keyspace_sharded'
+UNSHARDED_KEYSPACE = 'test_keyspace_unsharded'
 
 # shards for SHARDED_KEYSPACE
 # range '' - 80