Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for OFFSET keyword #2460

Merged
merged 1 commit into from Jan 17, 2017
Merged

Conversation

bbeaudreault
Copy link
Contributor

@bbeaudreault bbeaudreault commented Jan 14, 2017

We already supported LIMIT <offset>, <limit> but not the LIMIT <limit> OFFSET <offset> construct, per http://dev.mysql.com/doc/refman/5.7/en/select.html

This adds support and a test for this case

@sougou

@bbeaudreault
Copy link
Contributor Author

I should note that when we rewrite the query, we'll put it back to the LIMIT <offset>, <limit> syntax.

@sougou
Copy link
Contributor

sougou commented Jan 17, 2017

Can you resolve the conflict? Just need to regen sql.go.

@bbeaudreault
Copy link
Contributor Author

Will do

@bbeaudreault
Copy link
Contributor Author

Done, should be good once travis passes

@sougou sougou merged commit 4f9649b into vitessio:master Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants