Rbr: support horizontal sharding, and update stream. #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag defined in binlog is already defined in worker. No real binary includes both, but unit tests do.
And fixing bug it uncovered: propagating PK Type.
alainjobart
changed the title
sougou
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyspace_id resolver code is not unit tested, and is slightly different than the worker code. I have an action item to refactor that, and use the same for both places. The wiring will be a bit difficult, so not doing this just now.
Also, an action item on my list is to add a v3-based resharding test. Again, not in this PR.
This change also adds Update Stream support, with passing integration test.