Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type SendMessageBatchRequestEntryQueueTypeDef missing in mypy-boto3-sqs 1.34.101 #283

Closed
luizmineo opened this issue Jun 5, 2024 · 2 comments
Labels
🐞 bug Something isn't working 👋 response needed Awaiting response from a reporter

Comments

@luizmineo
Copy link

I recently upgraded my project from mypy-boto3-sqs 1.34.0 to 1.34.101, and noticed a type check error due to a missing type SendMessageBatchRequestEntryQueueTypeDef

After further investigation, it seems that 1.34.0 contains 2 identical TypeDict's: SendMessageBatchRequestEntryTypeDef and SendMessageBatchRequestEntryQueueTypeDef, and later versions contains only the first one.

According to the AWS documentation, the SendMessageBatchRequestEntry type is indeed the correct one, so I just want to confirm if this change was intentional, and it is safe to replace references to SendMessageBatchRequestEntryQueueTypeDef with SendMessageBatchRequestEntryTypeDef.

Thank you!

@luizmineo luizmineo added the 🐞 bug Something isn't working label Jun 5, 2024
@vemel
Copy link
Collaborator

vemel commented Jun 8, 2024

Hello! Thank you for the report.

Yes, the current behavior is correct, there should only be SendMessageBatchRequestEntryTypeDef. There used to be two of them because I had a logic to create a separate resource-specific TypeDef if it had different members or totality. Unfortunately, there was a bug that did not compare global and resource-specific TypeDefs correctly, so there was an unnecessary duplication.

Please let me know if this logic works for you as expected.

@vemel vemel added the 👋 response needed Awaiting response from a reporter label Jun 8, 2024
@luizmineo
Copy link
Author

Thanks for the response. Yes, it is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 👋 response needed Awaiting response from a reporter
Projects
None yet
Development

No branches or pull requests

2 participants