Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(field): add prop extra-event-params support #5184

Merged
merged 2 commits into from
Jan 11, 2023
Merged

feat(field): add prop extra-event-params support #5184

merged 2 commits into from
Jan 11, 2023

Conversation

landluck
Copy link
Contributor

@landluck landluck commented Jan 6, 2023

@chenjiahan
Copy link
Member

extra 这个 prop 命名不太好理解，感觉可以换个更准确的命名，然后在下个大版本作为默认行为

@landluck
Copy link
Contributor Author

landluck commented Jan 9, 2023

extra 这个 prop 命名不太好理解，感觉可以换个更准确的命名，然后在下个大版本作为默认行为

命名有什么建议吗，没有想到太合适的

@chenjiahan
Copy link
Member

叫 extra-event-params 好嘞，直观一些

@landluck
Copy link
Contributor Author

landluck commented Jan 9, 2023

叫 extra-event-params 好嘞，直观一些

OK

@landluck landluck changed the title feat(field): add prop extra support feat(field): add prop extra-event-params support Jan 11, 2023
@chenjiahan chenjiahan merged commit d14ac60 into youzan:dev Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@landluck @chenjiahan