Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(van-notice-bar): notice-bar early vanished when delay and scrollable were set #5547

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

fishjimi
Copy link
Contributor

@fishjimi fishjimi commented Sep 7, 2023

通知栏设置为scrollable且delay>0时,第二次及之后的滚动,内容还未到达顶端就重新播放动画
原因是定时器没有把delay加进去,动画过早重置

@landluck
Copy link
Contributor

改错地方了,要改源码,你改的是编译后的产物

@fishjimi
Copy link
Contributor Author

@landluck 辛苦再看看,这回应该改到源码了

@landluck landluck merged commit 42447bb into youzan:dev Sep 12, 2023
3 checks passed
@fishjimi fishjimi deleted the patch-1 branch September 12, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants