Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cli codependencies #58

Merged
merged 2 commits into from Oct 25, 2022
Merged

Support cli codependencies #58

merged 2 commits into from Oct 25, 2022

Conversation

yowainwright
Copy link
Owner

Proposed Changes

  • Adds full support for Codependence as a CLI only

Read about referenced issues here. Replace words with this Pull Request's context.

@ghost
Copy link

ghost commented Oct 25, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 25, 2022
View reviewed changes
src/scripts.ts
>;
const isModuleSafeCharacters = /[A-Za-z0-9\-_.]/.test(item)
if (!isModuleSafeCharacters) throw 'invalid item'
const cmd = !yarnConfig ? `npm view ${item} version latest` : `yarn npm info ${item} --fields version --json`

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

[String concatenation](1) which depends on [library input](2) is later used in [a shell command](3).
src/scripts.ts
>;
const isModuleSafeCharacters = /[A-Za-z0-9\-_.]/.test(item)
if (!isModuleSafeCharacters) throw 'invalid item'
const cmd = !yarnConfig ? `npm view ${item} version latest` : `yarn npm info ${item} --fields version --json`

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

[String concatenation](1) which depends on [library input](2) is later used in [a shell command](3).
@yowainwright yowainwright merged commit 047a3a4 into master Oct 25, 2022
@yowainwright yowainwright deleted the support-cli-codependencies branch October 25, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yowainwright