Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs: Hierarchy coloring and inheritance from an aliased page #11

Open
1 task done
stdword opened this issue Oct 18, 2022 · 13 comments · May be fixed by #64
Open
1 task done

Bugs: Hierarchy coloring and inheritance from an aliased page #11

stdword opened this issue Oct 18, 2022 · 13 comments · May be fixed by #64

Comments

@stdword
Copy link
Contributor

stdword commented Oct 18, 2022

Info:

  • OS: MacOS Monterey 12.6

  • Logseq ver: 0.8.9

  • Plugin ver: 1.9.7

  • Theme name: Panic theme Light (same bugs with default theme)

  • ⚠ Do i have issue with DISABLED my custom.css?

  1. Hierarchy coloring was broken:

    Expected: sub-pages have an icon and a color inherited from root page

  2. a) Create a page with color+icon settings and an alias:

    b) Rendering doesn't work for links when I use inheritance via an alias page (my inheritance works with tags property):

  3. Feature with removing icon for custom-texted links renders with errors. Icon exists at first opening of Logseq. But there is space char!
    https://gyazo.com/160912886f1c141c3e09818d3f193d43

@yoyurec
Copy link
Owner

yoyurec commented Oct 18, 2022

there are a lot of issues with latest 0.8.9
will fix old bug first, then switch to new...

@stdword stdword changed the title Some coloring bugs Bugs: Hierarchy coloring and inheritance from an aliased page Oct 19, 2022
@yoyurec
Copy link
Owner

yoyurec commented Oct 20, 2022

@stdword check latest v1.10.0 and tell not fixed issues or close an issue if all is ok

@stdword
Copy link
Contributor Author

stdword commented Oct 20, 2022

Sure!

  1. All plugin options was reset =(
  2. Bug with favicons:
    a) Some favicons doesn't render (left favicon: aw-links, right favicon: automatic-url-title plugin)
    048e6b0a38d719d1953058776b909b6b
    b) There is mistmatching with screen pixels: left icon scaled and blurred (earler the was no difference between them)
    b063f6d73683de801e73602d31587511
  3. Hierarchy coloring was fixed ✅
  4. For setting journalDefaultProps if I want to set a hex color system reqires me to skip double quotes
    color:: #79c396 — OK, but color:: "#79c396" — FAIL. Help text need as an example: this behaviour different then in manual setup
  5. Coloring for aliases wasn't fixed 🚫
    test tag 2022-10-21 00-06-53
    081ad4a3564e7eed60a825f1a2fa19e3
  6. Custom-texted links bug: probably fixed ✅ — I saw this bug, but now can't reproduce (during all the restarts and re-indexes)

@yoyurec
Copy link
Owner

yoyurec commented Oct 20, 2022

  1. All plugin options was reset =(

yes (( was refacoring of vars naming

  1. system reqires me to skip double quotes

will add to readme "no quotes!" )

aliases work in back direction.
if page have no props, plugin reads alias:: field and go there to get original page props

for now aliases & queries even broken in Logseq core ))

@yoyurec
Copy link
Owner

yoyurec commented Oct 20, 2022

Some favicons doesn't render

it's fun, cose we are using same GoogleAPI for icons )

more - it's code from SolExt(AwesomeLinks) ))))
https://github.com/0x7b1/logseq-plugin-automatic-url-title/blob/main/index.ts#L146-L179

@yoyurec
Copy link
Owner

yoyurec commented Oct 21, 2022

  1. Coloring for aliases wasn't fixed

not sure this case covered. put here content of files to reproduce...

@stdword
Copy link
Contributor Author

stdword commented Oct 22, 2022

not sure this case covered. put here content of files to reproduce...

Here are the steps to reproduce:
1a) Create page 1 with properties: tags:: test tag
1b) Create page 2 with properties: tags:: test alias tag
2) Create an alias for page test tag: alias:: test alias tag (+ coloring info)

@stdword
Copy link
Contributor Author

stdword commented Oct 22, 2022

more - it's code from SolExt(AwesomeLinks) ))))

HTML difference:

CSS difference:

If I just change width and height to 1.0em — icons render in the same way

@yoyurec
Copy link
Owner

yoyurec commented Oct 23, 2022

width 1.1em already changed, update plugin often)

@yoyurec
Copy link
Owner

yoyurec commented Oct 23, 2022

image

tell me )
image

@stdword
Copy link
Contributor Author

stdword commented Oct 23, 2022

With 1.0em it renders nice!

Content of base64 for google icon:
data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAFAklEQVRYhbVXW2xUVRRde99hpp3pdFKehYJiLZTysDyMPCSm0qAIajB+oNFEjP1AMdoETUBDAgZQJHw0GqMoIRp8kBhjNDRAgy9SBIqBQmgk0AEkLS2F0qGd6bQz52w/5nnn3rZTxPV179777LXOuefusw8hS2it8wE8KSJLAJQDKAbgjbtvA7gEoJGIDgPYz8y3s809FHGpUmqPUqpXsoRSKqSU2q21nnLHxCLiVkrtVEpFsyW2ERJRSu3QWucOd9ZTlVLn7pTYRsgZrXWJHRfZkM8VkYPMPDrTp661oO/XQ4icOonoFT90oAsQAef7YNxbDGf5XLgql8EommQ3qQ5mfoyITg8oQGs9VUTqM8lVWyuCuz5C35FfAJHBl48Irocr4FnzJozCCRYRRLSImS9aBGitPSJygpmnpw8K19Wip2Y7JNw7OHGmjlw3vOvehatiaaaIs0Q0n5l7AYATDhF5L5M89N2X6N6+adjkACC9IfQ3/GmxM/MsEdmcFBpXVSoi55jZSDjCdbXo3r7JNrmjuATOhxbBGF8EEEG1tqC/4SiizReSMTkrnoG3ej1Alm0GrXWUiMqY+SIBgFJqDzOvTgSoay24VfU8pC9sGmiML0Je9Xo45823FdZ/8hi6d26Fa3EF8taus41JE7HbMIwqEhGf1rqNmXMSzmDNGwj9fMw0YETZTPi21YC8XkuydEgoCHJ7Bo2JCwgRUSGLyIp0cun1w1W2C64HO5LBPHIU8rfsHJIcQFbkAMDMbgDLWWK1PTWD9n2AoeFe2gLPyssgp8DzylqwryCrxMOBiCxxIHawpIydvyWfnWVdcBTlwVm57K6Tx1HuQOxUSwkINpkijCkLAIdjwAyV24JZs21c6ULFdFOuYkbqSI0h0mF6pVzbEn5HaO2yVFEf2wX+X+iPWss4I9ZMpDBijOlVQhdwt+BxWYpSwIFYJzMqYaG8GZDO9mREW1cTxuooRrD9Pjj8jv1vd6lDo+pzcwkf57MI8DOAxnQLFTyafD7QNxHPtRaj9vLvtiSD4USzstimjjcyTY0c7+FSAsatQgQO7Oh5AJu75yIMA5+c/QY3w11Zk/eEBd8fj5hs94xmFGasABEdZgD7tdbJtaLcyfjMswE/hCcnAzvDAVT/sQ2B/u4hySMK2PJjHzqD5g33RLn5E8ZLcS3Hu9dv052rZq2B25FjGvD3LT9ePPg2jrT+NSD5ha4reHX/PjT4+032kR7CU3Mse+hrIupJHMdTRKSJObXTDlw5go3HamyJJucXYWHhHEzKKwQR4XrvTZy63oTGG+chEBjhErjbXwdFY+V787M5WFya+v5a60j8OG5OfhSl1A5mfiudaO/5n1Bz+qsBZzwYSHmR2/4aXp5XjtWPOE0+rfUHhmFsANJaMhFxa62PM/PM9OBD/9Rja8OnCEWH1xUZZKCq7AVUzXo6k7yRmRcQUdgkIO4sEZGjzGyqRm2hG/i4cS/qrtZDD9WUApg3dgaqZ7+EaQWmYwZa63ZmXkRE/oTNUhlEZLbW+lCmCAC4FuxA3dV6NLSfRXPgKm71BSAC+Fxe3OudgNljpqFy4kKUFtxnEaW1bieix5m50eK0CS5RSp25ixeT0yJSPCRxhohcpdSHSqnIfyDuV0q9LyI5QzMOvhpfKKWCwyAOKqV2aa3vHyq/tWceWIgXwHIxX899cXcAgB/x6zkR1RJRTzZ5/wXdyH6XrEznkwAAAABJRU5ErkJggg==

@stdword
Copy link
Contributor Author

stdword commented Oct 29, 2022

  1. Coloring for aliases wasn't fixed

not sure this case covered. put here content of files to reproduce...

Hi! @yoyurec, do you have a plans to figure out this case?

@stdword
Copy link
Contributor Author

stdword commented Nov 25, 2022

In v1.14.3 the bug still exists:

@MillironX MillironX linked a pull request May 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants