Do not clear ENV config vars #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not some mega bash expert, but seems to work backwards compatibly just fine and now I can actually install manpages by passing the ENV variable. |
According to the docs it is possible to configure kerl both by using `.kerlrc`
and passing ENV variables from the command-line, i.e.
KERL_INSTALL_MANPAGES=yes ./kerl install <build> <path>
However the ENV vars were being cleared/overriden, so you could only use `.kerlrc`.
This fixes it.
|
@spawngrid Is there a reason for this not being merged? |
|
Bump. Perhaps the optional parameters can be commented out instead of being deleted for more clarity on what options are available. |
|
Hmmm, and maybe this approach could be used to replace all the |
|
Let's get this included after we figure out what the merge conflict is. |
|
I have now rebased this branch, and fixed a related bug (2 more env vars were missed when backing up after reading I shall close this PR and submit a new one from that rebased branch. @yfyf thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs it is possible to configure kerl both by using
.kerlrcand passing ENV variables from the command-line, i.e.
However the ENV vars were being cleared/overriden, so you could only use
.kerlrc.This fixes it.