disconnect event not sent for more than one client

[jannschu]

Hi,

following situation: there are two (ore more) clients connected via xhr-multipart (Firefox 4 here).
The first client disconnects and after the timeout the first disconnect message is sent.
Then the second client disconnects and the second disconnect message is sent.

But if both disconnect together at nearly the same time (closing both tabs) only one event is triggered.
At least in 5 of 6 tries.

I hope this is reproducible.

[ferd]

I have a few ideas on this. First of all, is it something that looks a bit like [https://github.com//issues/42](issue 42)? In this case, entire queries are dropped, but it might be something similar.

It had a similar behaviour, and I think it has to do with how a query is handled or keepalive/pipelining. If you can give us some more details about what you're doing (or even demo code), I could try to see and confirm if it might be similar at some point in the very near future (a bit busy these days).

[jannschu]

I will build a small demo tomorrow.

[jannschu]

Here is the demo: http://pastie.org/2055824
Put these files into /demo/. Interesting fact: In line 33 (demo.erl) messages are sent to clients which aren't connected anymore. This line is necessary for the demo.

Edit: Firefox 4 produced some JavaScript errors, so I suggest to use Safari.

[ferd]

I've got an idea of what's happening. We've got a bug report related to socket.io stuff by another guy, this time with websockets. This has to do with how we're handling timers and timeout events.

I'll be rewriting the timeouts for all the events tonight and this should hopefully fix the issue.

[ferd]

Let me know if this still happens after the merge for now.

[jannschu]

It's working now, thank you!