-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having troble reproducing "ours-FC" #4
Comments
Oh, I will try to train SGCLS model based on this model and test it again. |
I'm still not able to reproduce the result, I got 0.67 on R@100 for the PREDCLS task using the trained SGCLS model. |
Hi, |
Sorry, I'm still not clear why the Bi-LSTM in ode block cannot be replaced by Linear layer. I thought this is how the paper describes "ours-FC":
I guess by " replace the LSTM before ODE-block", you mean:
I failed to record the result on R@50 because I thought it was not a satisfying result, but I can reproduce it soon (in about 10 minutes). |
ohh, i got you.. That part is written by another author, he misunderstood me. ours-FC means using FC before ODE-block. Then different network structures will provide different representations for the ODE block. |
OK, thank you, that makes sense. I will experiment with that setting to see if I can reproduce the result. Btw, the R@50 was 0.648, R@20 was 0.564. |
Are these scores (Re@50=0.648) using FC in ODE-block? |
Yes |
Ok that is reasonable, thanks |
That's a good news! Did you use our object detector? |
Sure, I got an even better result (R@50: 0.280 R@100: 0.314) later on epoch 7. Is there any difference between my implementation and the correct one? Though there seems to be no big problem with the other two tasks, the performance on SGCLS decreases significantly. |
Following the decribtion in the paper, I add a new ODE function:
class odeFunc3(nn.Module):
and replace the two odeFunc used in NODIS.py with it. Then I train the PREDCLS model with:
python models/train_rels.py -m predcls -order random -b 6 -p 100 -lr 1e-4 -ngpu 1 -ckpt checkpoints/vgdet/vg-24.tar -save_dir checkpoints/ -nepoch 20
But when I test the resulting model with:
python models/eval_rels.py -m predcls -order random -b 6 -p 100 -lr 1e-3 -ngpu 1 -test -ckpt checkpoints/vgrel-19-0.6350.tar -nepoch 50
I only got 0.658502 on R@100 for the PREDCLS task.
Did I miss anything?
The text was updated successfully, but these errors were encountered: