[BUG]: Royalty points redemption miscalculation

[ahashad]

Versions

-ERPNext: v12.18.0 (version-12)
-Frappe Framework: v12.15.0 (version-12)
-POS Awesome: v1.0.3 (master)

Stacktrace / full error message

It is miscalculation in royalty points redemption.

Steps to reproduce

1- Create loyalty program:
Collection factor = 1 ( 1 point for each dollar)
Conversion Factor = 0.05 ( 5 cent to each royalty point)
2- Create customer and add loyalty points for testing.
3- try to redeem some royalty point through POS Awesome

What is Expected?

1- Customer has 77 loyalty points
2- He can redeem upto 3.85$ ( 0.05 for each dollar)
Royalty cash = Royality points (77) x Conversion factor (0.05) = 3.85 $
3- After redemption the royalty points of customer must decrease by 77 points and add new 82 points for new purchase. the net will be 82 points

What is actually happening?

1- POS Awesome show wrong value in "You can redeem upto" field. It show customer can redeem upto 1540 $ not 3.85$. because of miscalculation. app uses a division not multiplication. ( 77 point / 0.05 (conversion factor) = 1540 $).
2- App does not deducted 77 royalty points - which customer has been used in previous purchase- from customer, so the royalty point increased from 77 to 159 points. the correct points must be 82 not 159.

Additional context

nothing

Screenshots

[olamide2]

Nice catch

The assumption was that you will do it the other way round.

USD 20 to earn 1 point
1 point = USD 1

Pending when @youssef does the fix you might want to change to this approach. It gives the customer the same points/usd at the end of the day.

[yrestom]

34127b9