build with stable rust #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bah, humbug. cc @apt1002 - Note that this is not a commitment to keep bad64 working with stable rust. I won't go out of my way to add unstable features, but I also won't introduce significantly worse code (not that this PR is) to have it work on stable in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So a wonderful person wrote an AARCH64 lifter for Falcon against these bindings :)! https://github.com/kawadakk/falcon/tree/aarch64-bad64
I want to bring these bindings into Falcon (we're working it falconre/falcon#108). In order for that to happen those bindings are going to need to build stable, which means bad64 will need to build stable.
This PR is a proposal to make bad64 build stable. It's probably slightly slower than the original. Very open to comments. Let me know.