Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to optimise number of columns. #29

Closed
kcubeterm opened this issue Jan 1, 2021 · 2 comments
Closed

Add option to optimise number of columns. #29

kcubeterm opened this issue Jan 1, 2021 · 2 comments

Comments

@kcubeterm
Copy link

kcubeterm commented Jan 1, 2021

Originally reported in termux/termux-packages#6100

Currently Rappel displays 4 registers per column. On Android termux with visible size font, the last row gets wrapped. Is it possible to display 2 register per column for a better register view on Termux Android screen

@yrp604
Copy link
Owner

yrp604 commented Jan 1, 2021

The relevant code is very straight forward and lives here for armv7: https://github.com/yrp604/rappel/blob/master/arch/armv7/display_armv7.c#L25-L45 (arm64 is nearly identical). The last argument to that function is the trailer when printing that register. As you should be able to see, it's currently grouped into blocks of four: tab, tab, tab, newline. If you were to split this into blocks of two (tab, newline, tab, newline) you'd get the desired behavior.

I don't think the phone use case is more popular than the desktop 80+ column terminal so I'm unlikely to change it across the board -- if you have any problems patching it please let me know.

@yrp604 yrp604 closed this as completed Jan 1, 2021
@kcubeterm
Copy link
Author

Thanks for your kind reply.

Happy new year btw 💝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants