Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can only delete one cookie at a time #9

Closed
bskendig opened this issue Mar 24, 2018 · 6 comments
Closed

Can only delete one cookie at a time #9

bskendig opened this issue Mar 24, 2018 · 6 comments

Comments

@bskendig
Copy link

Pressing the Delete key only deletes a single cookie at a time. If a site has six cookies, then I have to delete all six of them individually.

I'd like to be able to select a site then press Delete to get rid of all that site's cookies at once. I'd also like to be able to select multiple sites (using Shift or Ctrl to extend my selection) then press Delete once to get rid of all the cookies of all of the selected sites.

@bskendig
Copy link
Author

I just noticed there's a trashcan icon that'll delete all of a site's cookies. Still, that's a lot of mousing back and forth to delete each site individually. It would be a lot more convenient to use the Delete key, and to be able to select multiple sites to delete.

@inliquid
Copy link

inliquid commented Jul 4, 2018

This "trash icon" seems to delete ALL cookies at a browser not just for particular search! This is very annoying issue!

@ysard
Copy link
Owner

ysard commented Jul 5, 2018

The multiselection feature is in great demand but is a bit complex to implement for now, but I'm thinking about it.

@inliquid
The delete button we were talking about was removed in favor of the context menu. Only the button deleting all cookies from the context (and not from the browser as the text says in the current public version) has remained. I've added a warning window to warn the user that cookies in the current context will be deleted if it continues. It's more secure like that.

@inliquid
Copy link

inliquid commented Jul 5, 2018

@ysard no, I if tell you something, that means I had experience. I wouldn't spend time "imagining" of something. So once again. By clicking on delete all this software DELETED ALL COOKIES in web browser despite there was a search request. AND WITHOUT ANY WARNINGS!

@ysard
Copy link
Owner

ysard commented Jul 6, 2018

I never said that you imagined something. When bskendig talks about a "trashcan icon that'll delete all of a site's cookies", he's talking about a button that has been moved to the context menu. The only button remaining on the bottom left is the one you clicked. There is nevertheless an alert in the public version on addons.mozilla.org: a tooltip on mouse hover which indicates that this button "deletes all cookies" (while it only erases cookies of the current context (the default one by default )).

As I said, I added after your good remark an alert window that asks for confirmation for this dangerous action. I misspoke myself because this change is not yet published on AMO, but it's a matter of hours.

@ysard
Copy link
Owner

ysard commented Jul 6, 2018

I'm closing the issue because the same enhancement is mentioned on #12

@ysard ysard closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants