-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many failing tests #45
Comments
It looks like the problem originates when trying to specify a port; Prax returns a |
A breaking change in Crystal: |
Sorry, but even after pulling e9cd772 I am still getting a whole bunch of errors:
Do I need to wait for the next version of Crystal? |
No, only Crystal 0.20.5. I have no idea why it fails so badly for you. Does the built binary work normally? If so, then maybe the Ruby tests are at fault? |
Yeah, the binary has worked fine. Are there any dependencies for the tests that I might not have installed? |
Bundler should have you set. I think I'm running Ruby 2.1, maybe that's the difference. |
Still getting all these errors on 2.1.0. :/ I guess if I want to make a contribution, I'll have to either request that you run the tests, or that we set up Travis to run them for me. Sorry about that. |
Hi, I'm trying to make changes to this library, however a lot of the tests are failing for me on
master
:Note that, for the above output, I added "--trace --verbose" to "bundle exec rake test --trace --verbose" in the Makefile before running
make test
.I was wondering if you are seeing this too. If so, can we work to fix the tests? Or if not, any idea what's wrong on my end?
System is Debian 8 GNU Linux. Ruby is 2.3.1. Crystal is 0.20.5. Rackup is "Rack 1.3 (Release: 2.0.1)". Rake is "rake, version 10.4.2".
The text was updated successfully, but these errors were encountered: