Migrate to AGP 3.0 #102
Merged
Migrate to AGP 3.0 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⬆️ BuildScan plugin to 1.9 for compatibility reasons
yshrsmz
requested changes
Oct 8, 2017
Migrate configurations (compile -> implementation, provided -> compileOnly). Adjust output APK renaming script
|
Sorry for that! I've added the thingy, although tests ran from command line work for me always, so I missed that. Tests ran from AS failed, and now they passed so it should be ok. If not, then maybe I'll need to disable AAPT2 as well |
yshrsmz
approved these changes
Oct 8, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates to Android Gradle Plugin 3.0.0-beta7 (most recent as of now). This required updating Gradle, which in turn required updating build scan plugin as well.
Issue: #100
I see that the wercker build has failed, might be due to upgraded Gradle - older daemons conflict with the new one sometimes. I can't see build details, but
./gradlew assembleDebug testDebugUnitTest createDebugUnitTestCoverageReport -PdisablePreDexlocally works fine after./gradlew --stop