Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callbackify won't callback if the callback is the only argument #25

Closed
hurrymaplelad opened this issue Dec 8, 2015 · 1 comment
Closed
Labels

Comments

@hurrymaplelad
Copy link

This prints done as expected:

callbackify(function() {
  return Y.resolve('a');
})(1, function() {
  return console.log('done');
});

while this does not:

callbackify(function() {
  return Y.resolve('a');
})(function() {
  return console.log('done');
});

The only difference is the first example passes an extra (unused) argument to the function returned by callbackify.

@ysmood ysmood added the bug label Dec 8, 2015
@ysmood ysmood closed this as completed in e057d3e Dec 8, 2015
@ysmood
Copy link
Owner

ysmood commented Dec 8, 2015

Thanks for your report. I have added two test cases for this function. The fixed new version has published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants