Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move songTypes, genres, artists, and tags field queries to user #821

Closed
yss14 opened this issue Nov 6, 2019 · 0 comments · Fixed by #827
Closed

Move songTypes, genres, artists, and tags field queries to user #821

yss14 opened this issue Nov 6, 2019 · 0 comments · Fixed by #827
Labels
backend graphql schema
Projects
Kanban Board
Milestone
First Release

Comments

@yss14
Copy link
Owner

yss14 commented Nov 6, 2019 •
edited

Since #804 it doesn't make sense anymore that SongTypes, Genres, Artist, and Tags can belong to a Share, but only to a Library. It also doesn't make sense to query those types in aggregations on Shares, but rather handle those aggregations as a pool of SongTypes, Genres, Artist, and Tags over all linked Libraries.
Thus, moving the related subqueries songTypes, genres, artists, and tags from Share to User is a logical consequence.
@yss14 yss14 added this to the First Release milestone Nov 6, 2019
@yss14 yss14 added this to To do in Kanban Board via automation Nov 6, 2019
This was referenced Nov 6, 2019
Closed
Merged
@yss14 yss14 closed this as completed in #827 Nov 7, 2019
Kanban Board automation moved this from To do to Done Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend graphql schema
Projects
Kanban Board
  
Done
Milestone
First Release
Development

Successfully merging a pull request may close this issue.

feature: graphql schema move share subqueries to user yss14/musicshare
1 participant
@yss14