Additional metallicity mass fraction conversions #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For posterity this is a partial revival of #240 |
neutrinoceros
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
LGTM
leaving this open for a couple days in case @ngoldbaum would like to review this too
|
@brittonsmith @ngoldbaum want to have a look at this? |
|
I don't have a strong opinion here. I find the four letter abbreviations a bit confusing, but if they'd make sense to a new user then they're fine. I was waiting on Britton to weigh in because I figured he'd have more domain knowledge to say if the chosen names and approach make sense. |
|
@ngoldbaum FWIW they follow this convention used in the XSpec X-ray fitting package (and in pyXSIM): https://heasarc.gsfc.nasa.gov/xanadu/xspec/manual/node116.html |
|
Could we get one more approval here? Either @brittonsmith or @ngoldbaum |
brittonsmith
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several other common values for the solar metallicity found in the literature as new metallicity units, e.g.
"Zsun_angr", etc.The default mass fraction in
"Zsun"is still the one from Cloudy and has not been touched.Explanatory documentation has been added.