Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new ipycanvas #55

Closed
matthewturk opened this issue Jul 24, 2020 · 2 comments
Closed

Update for new ipycanvas #55

matthewturk opened this issue Jul 24, 2020 · 2 comments

Comments

@matthewturk
Copy link
Member

We need to make sure we're up to date for https://github.com/martinRenou/ipycanvas/pull/111 where the way the layout and image sizes are affected once #53 goes in.

@martinRenou
Copy link

Note that the default behavior of ipycanvas should not change. You might see ipycanvas behavior changes only if you manipulate the layout property.

@matthewturk
Copy link
Member Author

@martinRenou Thanks! What I want to check is that we're also getting our image size correct, since we supply that in the browser to a callback to generate the data. It's entirely possible we're doing everything as we should, but I just wanted to make a note in case we weren't. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants