Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axes labels always in code for spherical datasets, independent of "unit_system" #2913

Closed
n-claes opened this issue Sep 17, 2020 · 1 comment · Fixed by #3618
Closed

Axes labels always in code for spherical datasets, independent of "unit_system" #2913

n-claes opened this issue Sep 17, 2020 · 1 comment · Fixed by #3618

Comments

@n-claes
Copy link
Member

n-claes commented Sep 17, 2020

Bug report

Bug summary

@neutrinoceros discovered this when we went over #2728, what is happening is that the axes units are always in code units, independent of unit_system. It turns out that this is only the case for spherical datasets, and that it is not amrvac frontend-related. I managed to reproduce this issue with the KeplerianDisk dataset on the yt Hub as well, which is the athena_pp frontend.

Code for reproduction

blast = "amrvac/bw_2d0000.dat"
disk = "KeplerianDisk/disk.out1.00000.athdf"
for file, name in zip((blast, disk), ("amrvac", "athenapp")):
    ds = yt.load(file, unit_system="cgs")
    p = yt.SlicePlot(ds, "phi", "density")
    p.save(f"slice_cgs_{name}.png")

Actual outcome
AMRVAC dataset:
slice_cgs_amrvac
AthenaPP dataset:
slice_cgs_athenapp

Expected outcome
R and z axis labels in "cm".
For reference, this is a 3D Cartesian dataset ("amrvac/bw_3d0000.dat") sliced along y, same code as above:
slice_cgs_amrvac_cart
which behaves as it should.

@neutrinoceros
Copy link
Member

Reporting that the images produced by the example script have gotten better since #3533

�slice_cgs_amrvac
�slice_cgs_athenapp

... but this issue is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants