We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug summary
AthenaDataset._is_valid() is currently implemented as
AthenaDataset._is_valid()
@classmethod def _is_valid(self, *args, **kwargs): try: if "vtk" in args[0]: return True except Exception: pass return False
Note that the try/except block is basically useless and that the whole function is equivalent to
try/except
@classmethod def _is_valid(self, *args, **kwargs): return "vtk" in args[0]
This is a problem for two reasons:
YTAmbiguousDataType
I have no expertise with Athena so I'm not in a position where I can easily come up with a more robust validation function.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Bug report
Bug summary
AthenaDataset._is_valid()
is currently implemented asNote that the
try/except
block is basically useless and that the whole function is equivalent toThis is a problem for two reasons:
YTAmbiguousDataType
, as it happened in refactor: remove yt.funcs.ensure_tuple #3000I have no expertise with Athena so I'm not in a position where I can easily come up with a more robust validation function.
The text was updated successfully, but these errors were encountered: