BLD: functions that differ only in their return type cannot be overloaded (on FreeBSD)

[yurivict]

Bug report

Bug summary
Build fails on FreeBSD 13:

In file included from yt/utilities/lib/image_samplers.cpp:677:
yt/utilities/lib/platform_dep_math.hpp:15:13: error: functions that differ only in their return type cannot be overloaded
inline bool __isnormal(double x) {
       ~~~~ ^
/usr/include/math.h:189:5: note: previous declaration is here
int     __isnormal(double) __pure2;
~~~     ^

[welcome]

Hi, and welcome to yt! Thanks for opening your first issue. We have an issue template that helps us to gather relevant information to help diagnosing and fixing the issue.

[neutrinoceros]

Hi @yurivict, it seems that this could (maybe ?) be solved by patching the preprocessor directives logic in yt/utilities/lib/platform_dep_math.hpp, though I don't know much about FreeBSD (or c++). @cphyc, @matthewturk, maybe you guys have ideas where to start ?

[cphyc]

Hi @yurivict, I have just created a fix (#3605) that works for me on Free BSD 13 w/ Python 3.8 (in a virtual box though).

Could you test this on your side?