Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWLS electron number density field returns no value #3838

Closed
cphyc opened this issue Mar 7, 2022 · 2 comments · Fixed by #3874
Closed

OWLS electron number density field returns no value #3838

cphyc opened this issue Mar 7, 2022 · 2 comments · Fixed by #3874
Assignees
Labels
bug code frontends Things related to specific frontends
Milestone

Comments

@cphyc
Copy link
Member

cphyc commented Mar 7, 2022

I randomly stumbled upon this piece of code which seems to be missing a return statement. Is that on purpose?

def _el_number_density(field, data):
n_e = data[ptype, "H_p1_number_density"]
n_e += data[ptype, "He_p1_number_density"]
n_e += 2.0 * data[ptype, "He_p2_number_density"]

@cphyc cphyc added bug code frontends Things related to specific frontends labels Mar 7, 2022
@matthewturk
Copy link
Member

Wow, yeah. Good point!

I don't remember who had taken on the OWLS frontend, but I think @chummels may have done some work with it (perhaps via EAGLE?) some bit ago.

@jzuhone
Copy link
Contributor

jzuhone commented Mar 8, 2022

I think I touched this last, will submit a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code frontends Things related to specific frontends
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants