Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: several small bugs in doc/source/PPVCube.ipynb #227

Open
neutrinoceros opened this issue Oct 2, 2023 · 5 comments
Open

BUG: several small bugs in doc/source/PPVCube.ipynb #227

neutrinoceros opened this issue Oct 2, 2023 · 5 comments

Comments

@neutrinoceros
Copy link
Member

Trying to run this notebook showed that it's not currently compatible with modern yt or astropy

#225 and #226 resolve the first couple issues, but there are more:

@neutrinoceros
Copy link
Member Author

I fixed a couple more issues in #228 but it's not over. I think that remaining errors (YTAmbiguousDataType, AttributeError, incorrect unit parsing ...) would benefit from someone else's look (@jzuhone ? @brittonsmith ? @cphyc ?)

@jzuhone
Copy link
Contributor

jzuhone commented Oct 2, 2023

@neutrinoceros #187 is probably relevant (and should be finished and merged, tbh) but I haven't had a chance to check yet

@neutrinoceros
Copy link
Member Author

Seems fair. If I get no complaints about #228 I intend to merge it a couple days, and I'll assume the rest of the issues will be fixed later.

@jzuhone
Copy link
Contributor

jzuhone commented Oct 3, 2023

@neutrinoceros FWIW I'm the one who developed PPVCube and the only one who knows anything about it :) so you're waiting on me for #228, I'll try today

@neutrinoceros
Copy link
Member Author

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants