Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong crop height ratio according to available modes. #280

Closed
melancholy13 opened this issue Jan 4, 2019 · 6 comments
Closed

Wrong crop height ratio according to available modes. #280

melancholy13 opened this issue Jan 4, 2019 · 6 comments
Assignees
@nkezhaya
Labels
bug

Comments

@melancholy13
Copy link

It is strange for me:

fusuma.cropHeightRatio = 1.0
fusumaCropImage = true

I expect the photo to be square. And if:

fusuma.availableModes = [FusumaMode.camera, FusumaMode.library]

or

fusuma.availableModes = [FusumaMode.video, FusumaMode.camera]

Everything is good, the area of the photo and the photo itself are square. But if:

fusuma.availableModes = [FusumaMode.camera]

Despite cropHeightRatio and fusumaCropImage, photo area and photo itself are rectangular.
@nkezhaya nkezhaya self-assigned this Jan 6, 2019
@nkezhaya nkezhaya added the bug label Jan 6, 2019
@FrancoisObob
Copy link
Contributor

Same issue here : default ratio is not 1:1 for camera mode.

@nkezhaya
Copy link
Collaborator

nkezhaya commented Feb 5, 2019

I'll get to it as soon as I can. In the meantime: pull requests are appreciated

@FrancoisObob FrancoisObob mentioned this issue Feb 5, 2019
Closed
@FrancoisObob
Copy link
Contributor

FrancoisObob commented Feb 5, 2019 •
edited

#286

@nkezhaya
Copy link
Collaborator

nkezhaya commented Feb 5, 2019

@FrancoisObob Merci !

@FrancoisObob
Copy link
Contributor

new PR only for this fix :)

@nkezhaya
Copy link
Collaborator

nkezhaya commented Feb 5, 2019

Fixed in 1.3.2.

@nkezhaya nkezhaya closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkezhaya nkezhaya

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkezhaya @FrancoisObob @melancholy13