Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Please follow the guide below
xinto all the boxes [ ] relevant to your issue (like this:[x])Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2017.08.23. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Description of your issue, suggested solution and other information
there are a couple of issues with mp3 metadata postprocessing via
--add-metadata.(youtube-dl relies on ffmpeg for id3 tagging)
id3 tag info (output from mid3v2):
Comment tag
http://id3.org/id3v2.4.0-frames
the correct frame header ID for the comments is
COMM, but this doesn't appear to be implemented by ffmpeg.youtube-dl --add-metadatainvokes the following:ffmpeg -i infile -metadata 'comment=foo' outfilethis yields a
TXXX(User defined text information) frame with description='comment'. the problem with this is that many (most?) mp3 players don't display arbitraryTXXXframes in their tag viewers and editors, so the metadata is not accessible to the user without relying on external, advanced id3 tagging software.btw,
ffmpeg -i infile -metadata 'comm=foo' outfiledoesn't give aCOMMframe either.suggestion: consider using another ID3 lib to write metadata, especially for
COMMsupport.it might also be nice if miscellaneous metadata (especially
purl(original song url)) were appended to the comments so they can be viewed in popular mp3 player software.Date tag
the date format in the
TDRCframe appears to be noncompliant.it's being passed to ffmpeg in a noncompliant format, and ffmpeg doesn't fix it.
see:
http://id3.org/id3v2.4.0-structure
http://id3.org/id3v2.4.0-frames
the format currently being passed is
yyMMdd, and this might be taken directly from source metadata with no additional processing?suggestion: try to validate date format and process it into compliance before tagging