Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"--sub-lang" option should accept "/" as "OR" operator #25761

Open
35609902357 opened this issue Jun 23, 2020 · 0 comments
Open

"--sub-lang" option should accept "/" as "OR" operator #25761

35609902357 opened this issue Jun 23, 2020 · 0 comments

Comments

@35609902357
Copy link

In the configuration file user-provided subs can be preferred to auto-generated subs by passing both options in the preferred order

--write-sub --write-auto-sub

but it doesn't work for --sub-lang en --sub-lang de.

Often user-provided subs are not in the same language of the auto-generated subs (for example user-provided are en-GB, while auto-generated are en. This leads to skip the user-provided subs and download the auto-generated ones. Passing en-GB,en would embed both tracks, which is an undesirable outcome, especially since they are both listed as "English" in the output file.

Adding the / to give an order and download the first available only (as it is for video formats) would allow to have a configuration file like

--embed-subs --write-sub --write-auto-sub --sub-lang en-GB/en-US/en

or

--embed-subs --write-sub --sub-lang en/de/fr

and not to worry checking available languages every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant