Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redgifs downloads both best & worst quality versions #29382

Open
5 tasks done
ahsaassy opened this issue Jun 24, 2021 · 2 comments
Open
5 tasks done

Redgifs downloads both best & worst quality versions #29382

ahsaassy opened this issue Jun 24, 2021 · 2 comments

Comments

@ahsaassy
Copy link

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2021.06.06
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-F', '-v', 'https://redgifs.com/watch/qualifiedsubtlecrossbill']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.9.5 (CPython) - Linux-4.9.186-perf+-aarch64-with-libc
[debug] exe versions: ffmpeg 4.4, ffprobe 4.4
[debug] Proxy map: {}
[generic] qualifiedsubtlecrossbill: Requesting header
[redirect] Following redirect to https://www.redgifs.com/watch/qualifiedsubtlecrossbill
[generic] qualifiedsubtlecrossbill: Requesting header
WARNING: Falling back on generic information extractor.
[generic] qualifiedsubtlecrossbill: Downloading webpage
[generic] qualifiedsubtlecrossbill: Extracting information
[download] Downloading playlist: None
[generic] playlist None: Collected 2 video ids (downloading 2 of them)
[download] Downloading video 1 of 2
[info] Available formats for QualifiedSubtleCrossbill:
format code  extension  resolution note
0            mp4        unknown
[download] Downloading video 2 of 2
[info] Available formats for QualifiedSubtleCrossbill-mobile:
format code  extension  resolution note
0            mp4        unknown

Description

!!!! Warning: NSFW LINK !!!!

youtube-dl is supposed to download only the best version but on redgifs, both versions gets downloaded.

HQ version: 3Mbps 1080p H264 30fps (22MB)
-mobile version: 614KBps 480p H264 30fps (4.5MB)

As you can see above, RG serves a playlist so ytdl treats them as seperate videos and both get downloaded. Quality selection parameters (worstvideo / bestvideo) don't work at all. Also there is no format code so (-f) doesn't work either.
This was not the case i think about 3-4 months ago.

@rautamiekka
Copy link
Contributor

Yes, it's true:

$ youtube-dl -v "https://redgifs.com/watch/qualifiedsubtlecrossbill"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://redgifs.com/watch/qualifiedsubtlecrossbill']
[debug] Encodings: locale cp65001, fs utf-8, out utf-8, pref cp65001
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.8.10 (CPython) - Windows-10-10.0.19042-SP0
[debug] exe versions: none
[debug] Proxy map: {}
[generic] qualifiedsubtlecrossbill: Requesting header
[redirect] Following redirect to https://www.redgifs.com/watch/qualifiedsubtlecrossbill
[generic] qualifiedsubtlecrossbill: Requesting header
WARNING: Falling back on generic information extractor.
[generic] qualifiedsubtlecrossbill: Downloading webpage
[generic] qualifiedsubtlecrossbill: Extracting information
[download] Downloading playlist: None
[generic] playlist None: Collected 2 video ids (downloading 2 of them)
[download] Downloading video 1 of 2
[debug] Default format spec: best/bestvideo+bestaudio
[debug] Invoking downloader on 'https://thumbs2.redgifs.com/QualifiedSubtleCrossbill.mp4'
[download] Destination: Blonde Cory Chase Kiara Cole Lesbians MILF Pornstar Pussy Eating Porn GIF by pierre0685 (1)-QualifiedSubtleCrossbill.mp4
[download] 100% of 22.01MiB in 00:07
[download] Downloading video 2 of 2
[debug] Default format spec: best/bestvideo+bestaudio
[debug] Invoking downloader on 'https://thumbs2.redgifs.com/QualifiedSubtleCrossbill-mobile.mp4'
[download] Destination: Blonde Cory Chase Kiara Cole Lesbians MILF Pornstar Pussy Eating Porn GIF by pierre0685 (2)-QualifiedSubtleCrossbill-mobile.mp4
[download] 100% of 4.50MiB in 00:01
[download] Finished downloading playlist: None

, but if you look at these lines:

[generic] qualifiedsubtlecrossbill: Requesting header
[redirect] Following redirect to https://www.redgifs.com/watch/qualifiedsubtlecrossbill
[generic] qualifiedsubtlecrossbill: Requesting header
WARNING: Falling back on generic information extractor.
[generic] qualifiedsubtlecrossbill: Downloading webpage
[generic] qualifiedsubtlecrossbill: Extracting information

and take a look at https://github.com/ytdl-org/youtube-dl/search?q=redgifs you'll see ytdl doesn't support redgifs per se, instead it uses the generic support.

^ That's the reason it takes both: it sees 2 vids of diff names/ID's and doesn't have a concept of same-but-diff-qualities.

@ysateat
Copy link

ysateat commented Aug 31, 2021

youtube-dl-redgifs.patch.txt

I did this to use the gfycat extractor for redgifs links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants