-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File names are ugly in windows #500
Comments
That's not a Windows-specific issue; both Windows and Linux can handle spaces in file names fine. We had spaces in at one point, but disabled them. I'll look up why. |
Well, basically we don't have them in anymore because of me and my too much strict Not allowed now are char in u' .\\/|?*<>:"' or ord(char) < 32 probably space and dot are OK. Can I go with the patch? Even if this will break some "already downloaded" checks? The others aren't according to Wikipedia, but should we replace them with something else than |
Should be fixed with #502, and will be in the next release. |
[pull] master from ytdl-org:master
The default title sanitation replaces spaces with underscores, which is probably what most users want in Linux, but in Windows the titles should definitely keep their spaces.
I‘d be happy to provide a pull request for this, I’m just not sure how you would prefer this: I could either fix the default sanitation or add a new one (
%(ntitle)s
) that produces nicer titles.The text was updated successfully, but these errors were encountered: