CRI containerd job environment #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
koct9i
commented
Jan 17, 2024
•
koct9i
commented
- Cleanup handling legacy config layout
- Cleanup building spec for exec nodes
- Add jobResources and jobEnvironment into exec node spec
- Ignore typed nil in Fetch And Sync
- Add CRI job environment
- Add EntrypointWrapper into InstanceSpec
✅ All contributors are covered under a CLA with YandexSee CONTRIBUTING.md for more info about Yandex Contributor License Agreement. The following contributors were found: (Only the first commit for a unique contributor is listed) |
koct9i
force-pushed
the
cri-job-environment
branch
from
5428509
to
63cd571
Compare
l0kix2
requested changes
Feb 6, 2024
There was a problem hiding this comment.
I can't say much about containerd stuff here, suppose it's ok, but I suggest to add some testing (either e2e or envtest-based without real cluster — I hope some helpers for second option will be merged in main soon) for this new functionality.
Also I suppose we better test some existing exec nodes code current behaviour, it is not obviously to me we don't break anything from diff.
koct9i
force-pushed
the
cri-job-environment
branch
from
63cd571
to
d179d8a
Compare
l0kix2
requested changes
Mar 7, 2024
koct9i
force-pushed
the
cri-job-environment
branch
from
d179d8a
to
cc3555e
Compare
gritukan
reviewed
Mar 20, 2024
koct9i
force-pushed
the
cri-job-environment
branch
3 times, most recently
from
e229cfc
to
3966964
Compare
This code must be refactored.
This is useful for ad-hoc hacking, tuning, debugging or injecting sidecar workload right into component container.
koct9i
force-pushed
the
cri-job-environment
branch
from
3966964
to
0f41d84
Compare
gritukan
reviewed
Mar 22, 2024
gritukan
reviewed
Mar 22, 2024
gritukan
reviewed
Mar 22, 2024
gritukan
reviewed
Mar 22, 2024
koct9i
force-pushed
the
cri-job-environment
branch
from
0f41d84
to
0df7e1b
Compare
koct9i
force-pushed
the
cri-job-environment
branch
from
0df7e1b
to
00d6ac8
Compare
l0kix2
approved these changes
Mar 25, 2024
l0kix2
requested changes
Mar 25, 2024
l0kix2
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.