New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Official Image on Docker Hub #297
Comments
Yeah it's official. If someone wants to automate it, I'm sure @nopedial is happy to share credentials. |
I'd be happy to set up the configuration for this |
Happy to add you guys as collaborators, let me know your dockerhub logins. |
@nopedial |
@mikebryant done - let me know when you make progress so I can test |
@nopedial When I log in to dockerhub, I don't see anything different - the oxidized organisation doesn't give me any sort of access to change things. |
@mikebryant you are definitely added as collaborators to the repo - you should be able to push to the repo but not much else - there is no organization and teams for oxidized, just the repo. |
I've converted the user to an organization and added you as owner - let me know if you are able to change things now. |
@mikebryant no problem |
I believe this is now working |
Is this also working for tags or just for master? |
Only master - currently the Dockerfile uses the gem version rather than the repository contents, so tagged builds wouldn't necessarily reflect the right version. |
@mikebryant I feel using the repository content might make more sense, what are your feelings on this? |
I'd be happy with that. My only concerns/thoughs are about oxidized-web - are we happy for the docker build of oxidized to just pull in the latest version at the time of said build? |
I think it would be fine, any concerns from your side @ytti ? |
no concerns here |
I think this is done deal. Reopen if issues. |
I stumbled upon an Image on Docker Hub which looks like it's an official one. Said that, do you think it would be a good idea to have one?
As the build can be automated there should not be much work to keep it updated, after the initial setup, I guess.
The text was updated successfully, but these errors were encountered: