Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorscheme not written in BFC #32

Closed
yttrion opened this issue Apr 11, 2022 · 2 comments
Closed

Colorscheme not written in BFC #32

yttrion opened this issue Apr 11, 2022 · 2 comments
Labels
bug Something isn't working status:resolved

Comments

@yttrion
Copy link
Owner

yttrion commented Apr 11, 2022

While doomnvim now creates the BFC file, it won't save the default parameters inside, like the colorscheme, rolling back to the default
doomnvim colorscheme

@yttrion yttrion added bug Something isn't working status:investigating labels Apr 11, 2022
@yttrion yttrion added this to Known issues in Bugs via automation Apr 11, 2022
@yttrion yttrion added this to To do in Updates Apr 11, 2022
@yttrion
Copy link
Owner Author

yttrion commented Apr 11, 2022

Colorscheme is now written in $HOME/.doomrc file but not edited properly

Expected behaviour

When choosing colorscheme2 while colorscheme1 is the current theme, the BFC should change from this

let g:doomnvim_colorscheme="colorscheme1"

to this

let g:doomnvim_colorscheme="colorscheme1"

Actual behaviour

When choosing colorscheme2 while colorscheme1 is the current theme, the BFC change from this

...
let g:doomnvim_colorscheme="colorscheme1"
...

to this

...
let g:doomnvim_colorscheme="colorscheme1"
let g:doomnvim_colorscheme="colorscheme2"
...

@yttrion yttrion moved this from To do to In progress in Updates Apr 11, 2022
@yttrion
Copy link
Owner Author

yttrion commented Apr 11, 2022

Fixed with new doomnvim#functions#quitdoom() function

@yttrion yttrion closed this as completed Apr 11, 2022
Bugs automation moved this from Known issues to Fixed Apr 11, 2022
@yttrion yttrion moved this from In progress to Done in Updates Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:resolved
Projects
Bugs
  
Fixed
Updates
  
Done
Development

No branches or pull requests

1 participant