Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing react->preact alias for sub-packages #130

Open
gluck opened this issue Nov 18, 2022 · 0 comments
Open

Missing react->preact alias for sub-packages #130

gluck opened this issue Nov 18, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@gluck
Copy link

gluck commented Nov 18, 2022

When using a library which uses react/jsx-runtime, the configured preact alias plugin doesn't kick in and we end up bundling react (and having errors obviously).

I believe the plugin should be extended to support this alias as well (as per preact doc: https://preactjs.com/guide/v10/getting-started#aliasing-in-rollup ).
@gluck gluck changed the title Missing react->preact aias for sub-packages Missing react->preact alias for sub-packages Nov 18, 2022
@yuanqing yuanqing added the bug Something isn't working label Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gluck @yuanqing