Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React 17? #27

Closed
vitexikora opened this issue Mar 15, 2022 · 5 comments
Closed

Support React 17? #27

vitexikora opened this issue Mar 15, 2022 · 5 comments

Comments

@vitexikora
Copy link

Peer dependencies mention only React 16.8.
This makes it impossible to install in Node 16+ without legacy-peer-deps flag.. 馃槩
@adrianhelvik
Copy link

The react version in devDependencies should be changed to >=16.8.0 <=18.*.*. React supports the hooks this macro uses in all those versions.

@yuchi

@adrianhelvik
Copy link

Fixed in PR #29

@vitexikora
Copy link
Author

Can you please merge it @yuchi ?

@yuchi yuchi closed this as completed in 710df4e Nov 6, 2023
@yuchi
Copy link
Owner

yuchi commented Nov 8, 2023 •
edited
Loading

Should have been fixed in v1.2.0.
Sorry for the delay and for not having merged your PR.
PS: In future contributions do NOT upgrade the version please

@vitexikora
Copy link
Author

Thanks! Finally can get rid off legacy-peer-deps...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuchi @adrianhelvik @vitexikora