Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Add flag for configuring rocksdb bytes_per_sync option #10822

Open
ttyusupov opened this issue Dec 9, 2021 · 2 comments
Open

[DocDB] Add flag for configuring rocksdb bytes_per_sync option #10822

ttyusupov opened this issue Dec 9, 2021 · 2 comments
Assignees
Labels
area/docdb YugabyteDB core features good first issue This is a good issue to start contributing! kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@ttyusupov
Copy link
Contributor

ttyusupov commented Dec 9, 2021

Jira Link: DB-590

Description

  // Allows OS to incrementally sync files to disk while they are being
  // written, in the background. Issue one request for every bytes_per_sync
  // written. 0 turns it off.
  // Default: 0
  uint64_t bytes_per_sync = 0;
DBOptions SanitizeOptions(const std::string& dbname, const DBOptions& src) {
...
  if (result.rate_limiter.get() != nullptr) {
    if (result.bytes_per_sync == 0) {
      result.bytes_per_sync = 1024 * 1024;
    }
  }
...

Currently, we don't set bytes_per_sync explicitly, but we use a rate limiter, so it leads to sync every 1MB (independently for each file) at rocksdb level.

@ttyusupov ttyusupov added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features labels Dec 9, 2021
@ttyusupov ttyusupov added this to Backlog in YBase features via automation Dec 9, 2021
@bmatican bmatican added this to To do in Starter tasks via automation Dec 10, 2021
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label May 29, 2022
@bmatican bmatican assigned rthallamko3 and unassigned bmatican Jul 19, 2022
@bmatican bmatican added the good first issue This is a good issue to start contributing! label Jul 19, 2022
@mohatagarvit
Copy link

Hi,

Hope you are doing well!

I am Garvit Mohata, a MS CS student at UT Austin. My teammate (Kulin Shah) and I are taking the graduate Distributed Systems course and as a part of the course project, we are exploring the opportunity of contributing to the tikv open source repository.

This issue seems closely related to the content of the course so we were wondering if we can contribute to solve this issue.

Can you provide a bit more specific expectations and details to solve this issue and pointers if possible?
Thank you!

Regards,
Garvit

@rthallamko3
Copy link
Contributor

Hi @mohatagarvit , Refer to Yugabyte contribution page for instructions - https://docs.yugabyte.com/preview/contribute/core-database/checklist/ . Feel free to take up this issue. cc @Huqicheng in case you need references to this particular issue. If you get past the initial aspects, we can identify a couple more items in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features good first issue This is a good issue to start contributing! kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YBase features
  
Backlog
Development

No branches or pull requests

6 participants