Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a peer from the Raft quorum only if the load balancer would allow a new one to be added. #1218

Open
amitanandaiyer opened this issue Apr 17, 2019 · 2 comments
Assignees
Labels
area/docdb YugabyteDB core features help wanted We welcome your contributions for this issue! kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@amitanandaiyer
Copy link
Contributor

amitanandaiyer commented Apr 17, 2019

Jira Link: DB-2435
Currently, Raft groups independently kick out a failed peer from the quorum independently. However, adding new peers into the quorum is controlled by the master/load-balancer and throttled to limit the number of concurrent remote bootstraps.

We should make this symmetric so that a failed peer is kicked out of the quorum only when the load balancer actually has the bandwidth to add some other node to the quorum.

So, instead of a failed peer losing all the tablets that he had after 5 mins of absence, the new behavior will be to remove the failed peer from the tablets he owns in a throttled fashion. So, if he were to come back before the system has moved away all his tablets, he can start off from where he left on those tablets.

(This may require #1217 for this to be effective.)

@amitanandaiyer amitanandaiyer added the area/docdb YugabyteDB core features label Apr 17, 2019
@rkarthik007 rkarthik007 added the help wanted We welcome your contributions for this issue! label Jul 11, 2019
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 9, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Jul 28, 2022
@wudidapaopao
Copy link

@amitanandaiyer @rthallamko3 Does this task still require someone to do? Can I do it?

@rthallamko3 rthallamko3 assigned Huqicheng and unassigned rthallamko3 Jun 12, 2023
@amitanandaiyer
Copy link
Contributor Author

This would be useful only when we also have #1217 -- that would be a significant change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features help wanted We welcome your contributions for this issue! kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

6 participants