Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] TablePlus unable to load tables without primary key #1256

Open
ndeodhar opened this issue Apr 25, 2019 · 5 comments
Open

[YSQL] TablePlus unable to load tables without primary key #1256

ndeodhar opened this issue Apr 25, 2019 · 5 comments
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) help wanted We welcome your contributions for this issue! kind/bug This issue is a bug priority/medium Medium priority issue
Projects

Comments

@ndeodhar
Copy link
Contributor

ndeodhar commented Apr 25, 2019

Jira Link: DB-1507
For tables that don't have a primary key, TablePlus is not able to load the table. Error displayed is ERROR: System column with id -1 is not supported yet

@ndeodhar ndeodhar added the area/ysql Yugabyte SQL (YSQL) label Apr 25, 2019
@ndeodhar ndeodhar added this to the v2.0 milestone Apr 25, 2019
@ndeodhar ndeodhar self-assigned this Apr 25, 2019
@ndeodhar ndeodhar added this to To do in YSQL via automation Apr 25, 2019
@ndeodhar
Copy link
Contributor Author

In postgres log:

2019-04-24 17:30:52.089 PDT [95281] ERROR:  System column with id -1 is not supported yet
2019-04-24 17:30:52.089 PDT [95281] STATEMENT:  SELECT "ctid",* FROM "public"."bar" LIMIT 300 OFFSET 0;
2019-04-24 17:32:16.306 PDT [95281] ERROR:  System column with id -1 is not supported yet
2019-04-24 17:32:16.306 PDT [95281] STATEMENT:  SELECT "ctid",* FROM "public"."nopk" LIMIT 300 OFFSET 0;

@huyphams
Copy link

Hey @ndeodhar I'm the author of TablePlus. Could you please show me the title of the connection?
Screen Shot 2019-07-15 at 8 28 17 AM
Does it show YugaByte or something? TablePlus uses ctid in PostgreSQL to update the row, but YugaByte doesn't support it.

@ndeodhar
Copy link
Contributor Author

Hi @huyphams, TablePlus shows PostgreSQL title:
image

This is because we use PostgreSQL datatype while connecting to YB database. While we are compatible with Postgres, we have made changes to Postgres internals for YB. One example of this is changing ctid to a more YB specific ybctid.

We'd love to explore the possibility of building a custom integration for YugaByte with TablePlus. Let us know your thoughts.
cc: @schoudhury

@huyphams
Copy link

Thank you for your clarification.
I can update the PG driver to support YugaByte easily if the select version(); return the driver name.
For example:
In PostgreSQL: select version() returns PostgreSQL 11.0;
it would be great if YugaByte returns YugaByte _version_number; So I can change the query based on that information.

@ndeodhar
Copy link
Contributor Author

That'll be great @huyphams, appreciate it!
Created this issue for us to update select version():#1841
TablePlus integration will also depend on: #1284.

@rkarthik007 rkarthik007 removed this from the v2.0 milestone Jun 5, 2020
@ndeodhar ndeodhar moved this from To do to Backlog in YSQL Aug 5, 2020
@kmuthukk kmuthukk assigned m-iancu and unassigned ndeodhar Mar 9, 2021
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) help wanted We welcome your contributions for this issue! kind/bug This issue is a bug priority/medium Medium priority issue
Projects
Status: No status
YSQL
  
Backlog
Development

No branches or pull requests

5 participants