Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] [Snapshots] Include metadata in on-demand snapshots #12977

Open
vkulichenko opened this issue Jun 21, 2022 · 0 comments
Open

[DocDB] [Snapshots] Include metadata in on-demand snapshots #12977

vkulichenko opened this issue Jun 21, 2022 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@vkulichenko
Copy link
Contributor

vkulichenko commented Jun 21, 2022

Jira Link: DB-2708

Description

Currently, we don't properly support the in-cluster snapshot use case. The scenario is the following:

  1. Create a snapshot using the create_snapshot command.
  2. Make a schema change (for example, DROP TABLE).
  3. Restore the snapshot.

The table will not be restored, because snapshots do not include metadata info, so schema changes are not reverted. At the same time, we do include the metadata in snapshots created as a part of a schedule (for PITR).

Metadata should be included in all snapshots, regardless of how they are created. Ultimately, there should not be any difference between a snapshot created on-demand, or a snapshot created as a part of a schedule.

Metadata should be included by default when create_snapshot command is executed. For compatibility purposes, we can add a --exclude_metadata parameter that would force the command to behave as it does currently.

@vkulichenko vkulichenko added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Jun 21, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 21, 2022
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Jun 28, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants