Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is int64 to int assignment not being flagged by our build as ERROR? #1607

Open
kmuthukk opened this issue Jun 22, 2019 · 0 comments
Open
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@kmuthukk
Copy link
Collaborator

kmuthukk commented Jun 22, 2019

Jira Link: DB-2559
https://github.com/YugaByte/yugabyte-db/blob/760cc916798ecdf7e9f906e01a8fdbaa36538df2/src/yb/consensus/log_reader.cc#L340

Status LogReader::ReadReplicatesInRange(
    const int64_t starting_at,
    const int64_t up_to,
    int64_t max_bytes_to_read,
    ReplicateMsgs* replicates) const {
...
  for (int index = starting_at; index <= up_to && !limit_exceeded; index++) {

My understanding was that we set compiler WARNINGs to be treated as ERRORs, but somehow the starting_at to index assignment isn't getting flagged.

@kmuthukk kmuthukk added kind/bug This issue is a bug area/docdb YugabyteDB core features labels Jun 22, 2019
@kmuthukk kmuthukk added this to To Do in YBase features via automation Jun 22, 2019
@bmatican bmatican moved this from To Do to In progress in YBase features Jun 25, 2019
@bmatican bmatican moved this from In progress to To Do in YBase features Aug 27, 2019
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
YBase features
  
Backlog
Development

No branches or pull requests

3 participants