Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] New unit test to validate post split compactions and disk full scenarios. #16647

Open
1 task done
rthallamko3 opened this issue Apr 1, 2023 · 0 comments
Open
1 task done
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@rthallamko3
Copy link
Contributor

rthallamko3 commented Apr 1, 2023

Jira Link: DB-6031

Description

We would need to add a unit test that validates if the post split compaction runs into out of disk issues, the parent tablet continues to remain functional.

Based on the internal discussion, if post split compaction fails with out of disk - we can’t split tablet further until it is fully compacted.

void Tablet::TriggerFullCompactionSync(rocksdb::CompactionReason reason) {
  TEST_PAUSE_IF_FLAG(TEST_pause_before_full_compaction);
  WARN_WITH_PREFIX_NOT_OK(
      ForceFullRocksDBCompact(reason),
      Format("$0: Failed tablet full compaction ($1)", log_prefix_suffix_, ToString(reason)));
}

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@rthallamko3 rthallamko3 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Apr 1, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue kind/enhancement This is an enhancement of an existing feature and removed status/awaiting-triage Issue awaiting triage kind/bug This issue is a bug labels Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants