Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate table creation code in tests #5016

Open
robertsami opened this issue Jul 8, 2020 · 0 comments
Open

Consolidate table creation code in tests #5016

robertsami opened this issue Jul 8, 2020 · 0 comments
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@robertsami
Copy link
Contributor

robertsami commented Jul 8, 2020

Jira Link: DB-10465
We currently have a lot of tests which perform their own ad-hoc table creation. Rather than having this code (which is often verbose) spread throughout our tests we should have a unified helper that all of our tests can make use of.

For a sampling of places we're doing this:

gg ' CreateTable(.*{'
src/yb/benchmarks/yb_load_test_tool.cc:void CreateTable(const YBTableName &table_name, YBClient* client) {
src/yb/client/ql-tablet-test.cc:  void CreateTable(const YBTableName& table_name, TableHandle* table, int num_tablets = 0) {
src/yb/integration-tests/all_types-itest.cc:  Status CreateTable() {
src/yb/integration-tests/alter_table-test.cc:  Status CreateTable(const YBTableName& table_name) {
src/yb/integration-tests/clock_synchronization-itest.cc:  void CreateTable() {
src/yb/integration-tests/kv_table_ts_failover_write_if-test.cc:  void CreateTable() override {
src/yb/integration-tests/master_failover-itest.cc:  Status CreateTable(const YBTableName& table_name, CreateTableMode mode) {
src/yb/integration-tests/ts_itest-base.h:  void CreateTable() {
src/yb/integration-tests/update_scan_delta_compact-test.cc:  void CreateTable() {
src/yb/yql/cql/ql/test/ql-static-column-test.cc:  void CreateTable(TestQLProcessor *processor) {
src/yb/yql/pgwrapper/pg_wrapper_test_base.h:  void CreateTable(const std::string &statement) {

Let's consolidate and replace these uses where appropriate

@robertsami robertsami self-assigned this Jul 8, 2020
@robertsami robertsami added this to To Do in YBase features via automation Jul 8, 2020
@rthallamko3 rthallamko3 added the area/docdb YugabyteDB core features label Mar 19, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YBase features
  
Backlog
Development

No branches or pull requests

3 participants