Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The undo_submodule_changes.sh script does not work on git version 1.8.3.1 #5189

Open
mbautin opened this issue Jul 22, 2020 · 0 comments
Open
Assignees

Comments

@mbautin
Copy link
Collaborator

mbautin commented Jul 22, 2020

When all it needs to do is check out an old version (commit 5af111bc6e4e21a5c90dc6051ad814bc47642bf7 in this case) of the thirdparty submodule pointing to yugabyte-db-thirdparty, it tries to use the --name-only option and fails.

diff --git a/thirdparty b/thirdparty
index 5af111b..49ca690 160000
--- a/thirdparty
+++ b/thirdparty
@@ -1 +1 @@
-Subproject commit 5af111bc6e4e21a5c90dc6051ad814bc47642bf7
+Subproject commit 49ca690c1f5192d66f61c5b8da603f0eb57bce44
23:34 ~/code/yugabyte-db2 [2.1.8] $ cd thirdparty/
23:34 ~/code/yugabyte-db2/thirdparty (detached from 49ca690) $ gco 5af111bc6e4e21a5c90dc6051ad814bc47642bf7
Previous HEAD position was 49ca690... Add libedit to dependencies (#34)
HEAD is now at 5af111b... Re-try downloads of third-party dependencies (#19)
23:34 ~/code/yugabyte-db2/thirdparty (detached from 5af111b) $ cd ..
23:34 ~/code/yugabyte-db2 [2.1.8] $ git status
g# On branch 2.1.8
nothing to commit, working directory clean
23:34 ~/code/yugabyte-db2 [2.1.8] $ git diff
23:34 ~/code/yugabyte-db2 [2.1.8] $ bin/undo_submodule_changes.sh
error: unknown option `name-only'
usage: git config [options]

Config file location
--global use global config file
--system use system config file
--local use repository config file
-f, --file use given config file
--blob read config from given blob object

Action
--get get value: name [value-regex]
--get-all get all values: key [value-regex]
--get-regexp get values for regexp: name-regex [value-regex]
--replace-all replace all matching variables: name value [value_regex]
--add add a new variable: name value
--unset remove a variable: name [value-regex]
--unset-all remove all matches: name [value-regex]
--rename-section rename section: old-name new-name
--remove-section remove a section: name
-l, --list list all
-e, --edit open an editor
--get-color find the color configured: [default]
--get-colorbool
find the color setting: [stdout-is-tty]

Type
--bool value is "true" or "false"
--int value is decimal number
--bool-or-int value is --bool or --int
--path value is a path (file or directory name)

Other
-z, --null terminate values with NUL byte
--includes respect include directives on lookup

23:34 ~/code/yugabyte-db2 [2.1.8] $ git --version
git version 1.8.3.1

@mbautin mbautin self-assigned this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant