Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docdb: move TableNameResolver to pgwrapper #6868

Open
jaki opened this issue Jan 13, 2021 · 1 comment
Open

docdb: move TableNameResolver to pgwrapper #6868

jaki opened this issue Jan 13, 2021 · 1 comment
Assignees
@deeps1991
Labels
area/docdb YugabyteDB core features good first issue This is a good issue to start contributing! kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YBase features

Comments

@jaki
Copy link
Contributor

jaki commented Jan 13, 2021 •
edited by yugabyte-ci

Jira Link: DB-1650
TableNameResolver by @d-uspenskiy looks useful for tests, but it exists in yb-admin code. How about we move it to client so that tests can use it. For example, PgLibPqTest has its own helper GetTableIdByTableName, and TableNameResolver can be used instead.
@jaki jaki added the area/docdb YugabyteDB core features label Jan 13, 2021
@jaki
Copy link
Contributor Author

jaki commented Jan 16, 2021

Problem with putting it in client is that I didn't want pgwrapper tests to be calling client functions to get this. Maybe the best place for this to live is pgwrapper, in pq_utils library, so that pgwrapper tests can run the code natively. Switching title.

@jaki jaki changed the title docdb: move TableNameResolver to client docdb: move TableNameResolver to pgwrapper Jan 16, 2021
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 8, 2022
@yugabyte-ci yugabyte-ci added the good first issue This is a good issue to start contributing! label Jul 27, 2022
@yugabyte-ci yugabyte-ci assigned lingamsandeep and unassigned m-iancu Jul 27, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Jul 28, 2022
@deeps1991 deeps1991 assigned deeps1991 and unassigned lingamsandeep Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeps1991 deeps1991

Labels
area/docdb YugabyteDB core features good first issue This is a good issue to start contributing! kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
YBase features
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
5 participants
@m-iancu @jaki @yugabyte-ci @deeps1991 @lingamsandeep