Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block checks to the tablet data integrity checker #7904

Open
zhaoalex opened this issue Apr 1, 2021 · 0 comments
Open

Add block checks to the tablet data integrity checker #7904

zhaoalex opened this issue Apr 1, 2021 · 0 comments
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
Data integrity

Comments

@zhaoalex
Copy link
Contributor

zhaoalex commented Apr 1, 2021 •
edited by yugabyte-ci

Jira Link: DB-1807
Currently the tablet data integrity checker (aa58dab) checks that all files are present and that file sizes are correct. We should expand this to verify blocks in sst files, so we can guard against overwrites/byte flips/etc.

Couple ideas:

  • We could iterate through the DB with ReadOptions verify_checksums true, but this is obviously impractical
  • upstream RocksDB added DB::VerifyChecksums in facebook/rocksdb@7848f0b which would be great
  • upstream RocksDB added full file sst checksums in facebook/rocksdb@4369f2c (I believe) which could also work and should be backwards compat, but requires sst files to be updated with checksums first
@zhaoalex zhaoalex added the area/docdb YugabyteDB core features label Apr 1, 2021
@zhaoalex zhaoalex added this to Backlog in Data integrity via automation Apr 1, 2021
This was referenced May 21, 2021
Open
Open
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 9, 2022
@yugabyte-ci yugabyte-ci added status/awaiting-triage Issue awaiting triage kind/enhancement This is an enhancement of an existing feature and removed status/awaiting-triage Issue awaiting triage kind/bug This issue is a bug labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
Data integrity
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhaoalex @yugabyte-ci