Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving TSTabletManager::VerifyTabletData() into a shared class #8156

Open
jmeehan16 opened this issue Apr 23, 2021 · 0 comments
Open

Comments

@jmeehan16
Copy link
Contributor

jmeehan16 commented Apr 23, 2021

It's likely that we will want to move VerifyTabletData() into a shared class so that it can be used to verify the master tablet data as well. However, to do so will require a bit of investigation to make sure we can do that safely. The code block in question:

void TSTabletManager::VerifyTabletData() {
  LOG_WITH_PREFIX(INFO) << "Beginning tablet data verification checks";
  for (const TabletPeerPtr& peer : GetTabletPeers()) {
    if (peer->state() == RUNNING) {
      if (PREDICT_FALSE(FLAGS_skip_tablet_data_verification)) {
        LOG_WITH_PREFIX(INFO)
            << Format("Skipped tablet data verification check on $0", peer->tablet_id());
      } else {
        Status s = peer->tablet()->VerifyDataIntegrity();
        if (!s.ok()) {
          LOG(WARNING) << "Tablet data integrity verification failed on " << peer->tablet_id()
                       << ": " << s;
        }
      }
    }
  }
}

If moveable, one possible location may be the TabletMemoryManager. @bmatican

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant