Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform][API] Nodeinstance, kmsconfig Raw Json Cleanup #8908

Open
mahendranbhat opened this issue Jun 15, 2021 · 1 comment
Open

[Platform][API] Nodeinstance, kmsconfig Raw Json Cleanup #8908

mahendranbhat opened this issue Jun 15, 2021 · 1 comment
Assignees
Labels
area/platform Yugabyte Platform team/platform-hi Tickets handled by HashedIn team
Projects

Comments

@mahendranbhat
Copy link
Contributor

mahendranbhat commented Jun 15, 2021

Description :
There are places where we just create raw json node and return that. Ebeans already has built in serialization and deserialization for DBJson fields.
In many cases these entities are also part of out API request responses and they end up polluting the API definition with raw opaque json fields instead of first class objects. Hence making this part of our API cleanup.
As a side effect this leads to much better code redability.

Fields included:

NodeInstanceJson
kmsconfig

@mahendranbhat mahendranbhat added area/platform Yugabyte Platform team/platform-hi Tickets handled by HashedIn team labels Jun 15, 2021
@mahendranbhat mahendranbhat self-assigned this Jun 15, 2021
@mahendranbhat mahendranbhat changed the title [Platform][API] TaskInfo, Healthcheck Raw Json Cleanup [Platform][API] Nodeinstance, kmsconfig Raw Json Cleanup Jun 15, 2021
@mahendranbhat mahendranbhat added this to In Review in Platform Jun 15, 2021
@mahendranbhat
Copy link
Contributor Author

@mahendranbhat mahendranbhat moved this from In Review to Needs QA/Docs in Platform Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Yugabyte Platform team/platform-hi Tickets handled by HashedIn team
Projects
Platform
  
Needs QA/Docs
Development

No branches or pull requests

1 participant