Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Ability to specify default gflag values for Platform universes #8948

Open
iSignal opened this issue Jun 16, 2021 · 0 comments
Open
Labels
area/platform Yugabyte Platform priority/high High Priority
Projects
Milestone

Comments

@iSignal
Copy link
Contributor

iSignal commented Jun 16, 2021

Gflag values have default values that are specified in (C++) code. We want to be able to specify a different default from the C++ code default for certain gflags for dbs set up through Platform.

For example, we want to set the gflag fail_on_out_of_range_clock_skew=false for Platform universes though it is set to true in OSS universes. This is because we want to handle clock skew issues through alerts rather than crashes in the Platform case.

This will involve:

  1. Set the gflag to this value for newly created Platform universes for VMs
  2. Set the gflag to this value for newly created k8s universes > certain version when this gflag was introduced.
    This is because unknown gflags cause k8s yb processes to crash (VMs use conf files instead). We can avoid this logic by fixing [k8s] [YW] Use flagfile to specify gflags to yb-master/tserver in helm chart #6684
  3. Set the gflag to this value when an already created VM universe is upgraded through this Platform (software upgrade).
  4. Set the gflag to this value when an already created k8s universe is upgraded through this Platform (software upgrade)

For the k8s work, we will also need to complete the helm chart versioning work (#8950).

@jvigil-yugabyte @bmatican @streddy-yb

@iSignal iSignal added the area/platform Yugabyte Platform label Jun 16, 2021
@hsu880 hsu880 added this to the 2.7.x milestone Jun 18, 2021
@hsu880 hsu880 added this to Backlog in Platform Jun 18, 2021
@hsu880 hsu880 added the priority/high High Priority label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Yugabyte Platform priority/high High Priority
Projects
Platform
  
Backlog
Development

No branches or pull requests

2 participants